-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "Setup auth org ID" action for Enterprise Customers #1979
Conversation
aaec175
to
e77729f
Compare
{{ enterprise_customer|capfirst }} | ||
{% endif %} | ||
› | ||
{% trans "Setup auth org ID" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where to put this translation, do I need to run a make command or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run make extract_translations
I think? https://github.com/openedx/edx-platform/blob/2209549e68776f5db3c77a571bba115918fcf3f7/Makefile#L40-L53
That said, you're making changes to an internal tool, so I wouldn't let this be a blocker.
f7f1575
to
75946f3
Compare
|
75946f3
to
5d9da6d
Compare
ENT-8169
screenshots
Button NOT present when the
ENTERPRISE_SSO_ORCHESTRATOR_CONFIGURE_EDX_OAUTH_PATH
setting is NOT defined:Button present when the
ENTERPRISE_SSO_ORCHESTRATOR_CONFIGURE_EDX_OAUTH_PATH
setting is defined:Clicking the button leads you to a confirmation page with help text:
Clicking "Setup auth_org_id" results in a success message displayed:
Finally, clicking "Cancel" navigates back to the "Change Enterprise Customer" screen with updated value for the "Auth org id" field.
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.